Re: [PATCH] sh: kgdb: Add missing #include <linux/sched.h>

[Geert Uytterhoeven]

On Thu, Jan 16, 2014 at 11:24 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Jan 16, 2014 at 11:20:00PM +0100, Geert Uytterhoeven wrote:
>> From: Wanlong Gao <gaowanlong@xxxxxxxxxxxxxx>
>>
>> arch/sh/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
>> arch/sh/kernel/kgdb.c:225:32: error: implicit declaration of function 'task_stack_page' [-Werror=implicit-function-declaration]
>> arch/sh/kernel/kgdb.c:242:23: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c:243:22: error: dereferencing pointer to incomplete type
>> arch/sh/kernel/kgdb.c: In function 'singlestep_trap_handler':
>> arch/sh/kernel/kgdb.c:310:27: error: 'SIGTRAP' undeclared (first use in this function)
>> arch/sh/kernel/kgdb.c:310:27: note: each undeclared identifier is reported only once for each function it appears in
>>
>> This is introduced by commit 16559ae48c76f1ceb970b9719dea62b77eb5d06b
>> ("kgdb: remove #include <linux/serial_8250.h> from kgdb.h").
>
> Which showed up in 3.9-rc1, seems that no one seems to care about this
> arch/config much :)

That's why I didn't dare to add a CC to stable myself ;-)

BTW, the patch is also a few months old.

>> Reported-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
>> Signed-off-by: Wanlong Gao <gaowanlong@xxxxxxxxxxxxxx>
>> [geert: Reworded and reformatted]
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxxxxxxx>
>
> Cc: stable <stable@xxxxxxxxxxxxxxx>
> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/