Re: [PATCHv2 3/3] Input: edt-ft5x06: Add DT support

[Jingoo Han]

On Friday, January 17, 2014 9:27 AM, Dmitry Torokhov wrote:
> On Thu, Jan 16, 2014 at 09:02:18AM +0100, Lothar Waßmann wrote:
> >
> > Signed-off-by: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/input/touchscreen/edt-ft5x06.txt      |   29 +++++
> >  drivers/input/touchscreen/edt-ft5x06.c             |  121 +++++++++++++++++---
> >  2 files changed, 132 insertions(+), 18 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> >

[.....]

> > +	if (gpio_is_valid(tsdata->reset_pin)) {
> >  		/* this pulls reset down, enabling the low active reset */
> > -		error = devm_gpio_request_one(&client->dev, reset_pin,
> > +		error = devm_gpio_request_one(&client->dev, tsdata->reset_pin,
> >  					GPIOF_OUT_INIT_LOW,
> >  					"edt-ft5x06 reset");
> >  		if (error) {
> >  			dev_err(&client->dev,
> >  				"Failed to request GPIO %d as reset pin, error %d\n",
> > -				reset_pin, error);
> > +				tsdata->reset_pin, error);
> >  			return error;
> >  		}
> >
> > -		mdelay(50);
> > -		gpio_set_value(reset_pin, 1);
> > -		mdelay(100);
> > +		mdelay(5);
> > +		gpio_set_value(tsdata->reset_pin, 1);
> > +		mdelay(300);
> 
> Hmm, this change seems unrelated to DT support.

Right, modifying delay timing is not related to DT support.
In this case, this patch should be split, and the patch should
address the reason why delay timing is modified.
Also, 300 msec is a huge delay. Thus, comment will be helpful.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/