Re: [PATCH V3 3/3] power: reset: use syscon driver to parse reboot register from scu

From: Alexander Shiyan
Date: Fri Jan 17 2014 - 12:00:26 EST


ÐÑÑÐÐÑÐ, 17 ÑÐÐÐÑÑ 2014, 17:52 +01:00 ÐÑ Arnd Bergmann <arnd@xxxxxxxx>:
> On Wednesday 15 January 2014, Feng Kan wrote:
> > +static int __init xgene_reboot_init(void)
> > {
> > arm_pm_restart = xgene_restart;
> > return 0;
> > }
> > device_initcall(xgene_reboot_init);
>
> This won't work on a generic kernel, since you unconditionally set the
> pm_restart function to your own, which is broken for everything else.
>
> Please keep the platform_driver to attach to the reboot device
> as you had before. It might be good to turn this into a generic
> "syscon-reset" driver that gets both the register number and
> the contents to write from the device node.

I am not sure but think the new driver for SYSCON GPIOs can be
reused for such purpose:
http://www.spinics.net/lists/devicetree/msg18221.html

---
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶Ÿÿà -»+ƒùdš_