Re: [PATCH] dcache: fix d_splice_alias handling of aliases
From: J. Bruce Fields
Date: Fri Jan 17 2014 - 16:04:14 EST
On Fri, Jan 17, 2014 at 10:39:17AM -0500, J. Bruce Fields wrote:
> On Fri, Jan 17, 2014 at 04:17:23AM -0800, Christoph Hellwig wrote:
> > Also the inode == NULL case really should be split out from
> > d_materialise_unique into a separate helper. It shares almost no
> > code, is entirely undocumented to the point that I don't really
> > understand what the purpose is, and the only caller that can get
> > there (fuse) already branches around that case in the caller anyway.
> I think I see what you mean, I can fix that.
- two callers (fuse and nfs) take advantage of the NULL case.
- d_splice_alias handles inode == NULL in the same way, and
almost every caller takes advantage of that.
So at least we wouldn't want to actually make the caller handle this
But maybe there's still some opportunity for cleanup or documentation.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/