Re: [PATCH 1/6] cgroup: make CONFIG_NET_CLS_CGROUP and CONFIG_NETPRIO_CGROUPbool instead of tristate
From: Daniel Borkmann
Date: Sat Jan 18 2014 - 06:26:55 EST
On 01/18/2014 02:08 AM, Li Zefan wrote:
> Cc: Daniel Borkmann <dborkman@xxxxxxxxxx>
> On 2014/1/18 2:11, Tejun Heo wrote:
>> net_cls and net_prio are the only cgroups which are allowed to be
>> built as modules. The savings from allowing the two controllers to be
>> built as modules are tiny especially given that cgroup module support
>> itself adds quite a bit of complexity.
>> The following are the sizes of vmlinux with both built as module and
>> both built as part of the kernel image with cgroup module support
>> text data bss dec
>> 20292207 2411496 10784768 33488471
>> 20293421 2412568 10784768 33490757
>> The total difference is 2286 bytes. Given that none of other
>> controllers has much chance of being made a module and that we're
>> unlikely to add new modular controllers, the added complexity is
>> simply not justifiable.
>> As a first step to drop cgroup module support, this patch changes the
>> two config options to bool from tristate and drops module related code
>> from the two controllers.
> I sugguested Daniel to do this for net_cls, and the change has been in
> I was planning to remove module support after that change goes into
> upstream. :)
I am fine with that, thanks Li.
>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>> Cc: Neil Horman <nhorman@xxxxxxxxxxxxx>
>> Cc: Thomas Graf <tgraf@xxxxxxx>
>> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
>> net/Kconfig | 2 +-
>> net/core/netprio_cgroup.c | 32 ++------------------------------
>> net/sched/Kconfig | 2 +-
>> net/sched/cls_cgroup.c | 23 ++---------------------
>> 4 files changed, 6 insertions(+), 53 deletions(-)
> The modular version of task_netprioidx() in include/net/netprio_cgroup.h
> can be removed.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/