Re: [PATCH] Adding hyperv.h to uapi headers
From: Bjarke Istrup Pedersen
Date: Sat Jan 18 2014 - 18:57:45 EST
2014/1/19 Borislav Petkov <bp@xxxxxxxxx>:
> On Sun, Jan 19, 2014 at 12:24:10AM +0100, Bjarke Istrup Pedersen wrote:
>> I have submitted a v2 patch - does it look better?
> If you mean this:
> include/linux/hyperv.h | 321 +----------------------------------------
> include/uapi/linux/Kbuild | 1 +
> include/uapi/linux/hyperv.h | 344 ++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 347 insertions(+), 319 deletions(-)
> create mode 100644 include/uapi/linux/hyperv.h
> you've got the rough idea of uapi headers :-).
Yep, that one, thanks :-)
> Whether that makes sense at all in the hyperv case, you'll have to wait
> for the hyperv guys to say something.
> What makes me wonder is why do you need to export this now?
To be able to build the kvp deamon, which has been broken since the
UAPI split a few versions ago.
> Because if those userspace hyperv tools would really need the
> definitions in that header, then they never did build before. Which
> would be really stupid. Btw, which userspace hyperv tools do you mean?
> Where are they?
The tool located in tools/hv.
For some reason, this was never fixed, but now my machines started
complaining in dmesg that the kvp deamon should be updated, so I took
a look at it.
> What am I missing?
> Sent from a fat crate under my desk. Formatting is fine.
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/