Re: [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110.

From: Souvik Banerjee
Date: Mon Jan 20 2014 - 11:07:02 EST

Forgot to cc the LKML.

-------- Original Message --------
Subject: Re: [PATCH] dell-wmi: Add KEY_SWITCHVIDEOMODE for Dell N4110.
Date: Mon, 20 Jan 2014 10:05:03 -0600
From: Souvik Banerjee <souvik1997@xxxxxxxxx>
To: Matthew Garrett <mjg59@xxxxxxxxxxxxx>

No, I don't think so. My testing shows that it is now just reported by
the keyboard controller. My commit is similar to
'f1566f0dc07ec9b5409b348070f5a700032d7881' in which keys for the Dell
XPS L502X are added to the legacy keymap to reduce the noise. Without
this patch dell-wmi reports an unknown key, but with it those messages
are silenced.

Souvik Banerjee

On 01/20/2014 09:31 AM, Matthew Garrett wrote:
> On Mon, Jan 20, 2014 at 09:28:22AM -0600, Souvik Banerjee wrote:
>> This key is reported by the keyboard controller but also generates WMI
>> events. By adding it to the legacy keymap the WMI messages can be
>> silenced.
> Wouldn't this result in it being reported twice?

Attachment: signature.asc
Description: OpenPGP digital signature