Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within aUSB payload burst [NEW HARDWARE]
From: Sarah Sharp
Date: Mon Jan 20 2014 - 13:15:05 EST
On Mon, Jan 20, 2014 at 11:21:14AM +0000, David Laight wrote:
> From: walt
> > On 01/17/2014 06:34 AM, David Laight wrote:
> > > Can you try the patch I posted that stops the ownership on LINK TRBs
> > > being changed before that on the linked-to TRB?
> > Please disregard my earlier post about the patch not applying cleanly.
> > That was the usual html corruption, so I found the original on the usb
> > list and it was okay.
> > Sadly, the patch didn't fix the ASMedia lockup behavior, however :(
> > I did notice that the lockup occurred only when copying *to* the usb3
> > drive, and not when copying from it. I think that may be new behavior
> > but I can't swear to it.
> Consistent with another report that says that ethernet worked provided
> that TSO was disabled (ie no sg tx).
> (Without the patch to delay he ownership change on link trbs it didn't
> work at all.)
Please be more clear. What do you mean by these statements? That
someone privately reported that your earlier patch  did not help
them, but applying your new patch  on top of the old patch did?
In general, will you please Cc me and the USB list when replying to
privately reported bugs/confirmations that patches work? Or if the
confirmation was reported, please provide a link to the mailing list
discussion or bugzilla entry. We need to keep bug and fix confirmations
publicly archived. Please keep me on Cc since I filter mail based on
> A guess...
> In queue_bulk_sg_tx() try calling xhci_v1_0_td_remainder() instead
> of xhci_td_remainder().
Why? Walt has a 0.96 xHCI host controller, and the format for how to
calculate the TD remainder changed between the 0.96 and the 1.0 spec.
That's why we have xhci_v1_0_td_remainder() and xhci_td_remainder().
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/