Re: [RFC PATCHv2 2/2] Change khugepaged to respect MMF_THP_DISABLEflag

[Oleg Nesterov]

On 01/20, Alex Thorlton wrote:
>
> No, definitely not.  Upon review, khugepaged_test_exit is the wrong
> place to do this check.  I think I need to move it up to
> khugepaged_scan_mm_slot for this to work correctly.

Why? unless a MMF_THP_DISABLE task does madvise(MADV_HUGEPAGE)
khugepaged_scan_mm_slot() should never see its ->mm ?

Although I got lost a bit, and probably misunderstood... but it
seems to me that whatever you do this patch should not touch
khugepaged_scan_mm_slot.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/