Re: math_state_restore and kernel_fpu_end disable interrupts?

From: Nate Eldredge
Date: Mon Jan 20 2014 - 21:23:04 EST


On Sun, 19 Jan 2014, George Spelvin wrote:

It's credited to Suresh Siddha, whom I've cc'ed (along with others who
signed off). Suresh, if you're still around, could you comment on why
math_state_restore always leaves interrupts disabled, regardless of their
state on entry? Is there a deep reason or is it a bug?

What the comments seemed to be implying was that it was a bug to enter
this code with interrupts enabled. So the problem may be a little bit
more systemic; expert counsel is required.

It would be kind of weird for code that requires disabled interrupts on entry to turn around and enable interrupts itself. I agree that it would really help for a guru to take a look...

On which note, Suresh's email bounced :-(

--
Nate Eldredge
nate@xxxxxxxxxxxxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/