Re: [PATCH] Add HID's to hid-microsoft driver of Surface Type/TouchCover 2 to fix bug

From: Reyad Attiyat
Date: Tue Jan 21 2014 - 02:33:44 EST

On Tue, Jan 21, 2014 at 12:47 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> On Mon, 20 Jan 2014, Reyad Attiyat wrote:
>> The below patch fixes a bug 64811
>> ( of the Microsoft
>> Surface Type/Touch cover 2 devices being detected as a multitouch
>> device.
>> The fix adds the HID of the two devices to hid-microsoft driver. This
>> ensures that hid-input will eventually be used for the device and not
>> hid-multitouch.
> Hi,
> your patch is missing hid_have_special_driver[] entry, therefore correct
> driver binding is not guaranteed.
> --
> Jiri Kosina
> SUSE Labs


Thanks for reminding me of hid_have_special_driver[]. I noticed that
this device has the HID_DG_CONTACTID and in the comment of the

* Please note that for multitouch devices (driven by hid-multitouch driver),
* there is a proper autodetection and autoloading in place (based on presence
* of HID_DG_CONTACTID), so those devices don't need to be added to this list,
* as we are doing the right thing in hid_scan_usage().

This device should not be driven by hid-multitouch as it does not
handle keyboard/mouse input devices.
I submitted a new patch below with it added. I believe it should still
be part of this array, in case this kind of implementation is