Re: [PATCH] [trivial] ixgbe: Fix format string in ixgbe_fcoe.c

From: Brown, Aaron F
Date: Tue Jan 21 2014 - 18:05:02 EST


On Wed, 2014-01-15 at 01:14 +0900, Masanari Iida wrote:
> cppcheck detected following warning in ixgbe_fcoe.c
> (warning) %d in format string (no. 1) requires 'int' but the
> argument type is 'unsigned int'.
>
> Signed-off-by: Masanari Iida <standby24x7@xxxxxxxxx>
Tested-By: Jack Morgan <jack.morgan@xxxxxxxxx>
Signed-off-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>

> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> index f58db45..0872617 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c
> @@ -585,7 +585,7 @@ static int ixgbe_fcoe_dma_pool_alloc(struct ixgbe_fcoe *fcoe,
> struct dma_pool *pool;
> char pool_name[32];
>
> - snprintf(pool_name, 32, "ixgbe_fcoe_ddp_%d", cpu);
> + snprintf(pool_name, 32, "ixgbe_fcoe_ddp_%u", cpu);
>
> pool = dma_pool_create(pool_name, dev, IXGBE_FCPTR_MAX,
> IXGBE_FCPTR_ALIGN, PAGE_SIZE);


N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i