Re: [RFC/RFT][PATCH 4/5] ACPI / LPSS: Support for device latency tolerance PM QoS

[Rafael J. Wysocki]

On Monday, January 20, 2014 02:10:10 PM Rafael J. Wysocki wrote:
> On Monday, January 20, 2014 01:15:19 PM Mika Westerberg wrote:
> > On Fri, Jan 17, 2014 at 03:46:40PM +0100, Rafael J. Wysocki wrote:
> > > @@ -415,11 +472,12 @@ static int acpi_lpss_platform_notify(str
> > >  		return 0;
> > >  	}
> > >  
> > > -	if (action == BUS_NOTIFY_ADD_DEVICE)
> > > +	if (action == BUS_NOTIFY_ADD_DEVICE) {
> > >  		ret = sysfs_create_group(&pdev->dev.kobj, &lpss_attr_group);
> > > -	else if (action == BUS_NOTIFY_DEL_DEVICE)
> > > +		pdev->dev.power.set_latency_tolerance = acpi_lpss_set_ltr;
> > 
> > While trying to test this I noticed that BUS_NOTIFY_ADD_DEVICE happens
> > after call to dpm_sysfs_add(), so LTR field is never exposed to the
> > userspace.
> 
> Ahh, I confused things, thanks for reporting this!
> 
> I'll need to hook it up to acpi_platform_notify() somehow I think.

OK, two patches to replace this one ([4/5]) will follow.

On top of them we can move the code from acpi_lpss_platform_notify() to
acpi_lpss_(bind|unbind)() and get rid of acpi_lpss_nb, which I think would be
an improvement too. :-)

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/