Re: [PATCH] x86, cpu hotplug, use cpumask stack safe variantcpumask_var_t in check_irq_vectors_for_cpu_disable() [v2]

[Chen, Gong]

On Mon, Jan 20, 2014 at 01:57:58PM -0500, Prarit Bhargava wrote:
> Subject: [PATCH] x86, cpu hotplug, use cpumask stack safe variant
>  cpumask_var_t in check_irq_vectors_for_cpu_disable() [v2]
> 
> kbuild, 0day kernel build service, outputs the warning:
> 
> arch/x86/kernel/irq.c:333:1: warning: the frame size of 2056 bytes
> is larger than 2048 bytes [-Wframe-larger-than=]
> 
> because check_irq_vectors_for_cpu_disable() allocates two cpumasks on the
> stack.  Fix this by using cpumask_var_t, the cpumask stack safe variant.
> 
> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
> Cc: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> Cc: Michel Lespinasse <walken@xxxxxxxxxx>
> Cc: Seiji Aguchi <seiji.aguchi@xxxxxxx>
> Cc: Yang Zhang <yang.z.zhang@xxxxxxxxx>
> Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Cc: Janet Morgan <janet.morgan@xxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
> Cc: Ruiv Wang <ruiv.wang@xxxxxxxxx>
> Cc: Gong Chen <gong.chen@xxxxxxxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxxxxxxxx>
> Cc: Gong Chen <gong.chen@xxxxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> 
> [v2]: switch from GFP_KERNEL to GFP_ATOMIC

Reviewed-by: Chen, Gong <gong.chen@xxxxxxxxxxxxxxx>

Attachment: signature.asc
Description: Digital signature