Re: [PATCH v9 3/5] qrwlock, x86 - Treat all data type not biggerthan long as atomic in x86

[Waiman Long]

On 01/21/2014 07:31 PM, Linus Torvalds wrote:
> On Tue, Jan 21, 2014 at 8:09 AM, Waiman Long<waiman.long@xxxxxx>  wrote:
> > include/linux/compiler.h:
> >
> > #ifndef __native_word
> > # ifdef __arch_native_word(t)
> > #  define __native_word(t)      __arch_native_word(t)
> > # else
> > #  define __native_word(t) (sizeof(t) == sizeof(int) || sizeof(t) == siizeof(long))
> > # endif
> > #endif
> Do we even really need this?
>
> I'd suggest removing it entirely. You might want to retain the whole
>
>    compiletime_assert_atomic_type()
>
> thing on purely the alpha side, but then it's all inside just the
> alpha code, without any need for this "native_word" thing.
>
> And if somebody tries to do a "smp_store_release()" on a random
> structure or union, do we care? We're not some nanny state that wants
> to give nice warnings for insane code.
>
>                Linus

That sounds good to me too. Peter, what do you think about this?

-Longman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/