Re: Crash in elevator_dispatch_fn() (e.g. deadline_dispatch()) whenchanging elevators.

From: Frank Mayhar
Date: Wed Jan 22 2014 - 10:47:15 EST

On Tue, 2014-01-21 at 07:58 -0800, Frank Mayhar wrote:
> Replacing? Or adding to? Is BYPASS always set when DYING is set? (My
> guess is not but I haven't done an exhaustive analysis.) So the
> relevant code snippet in __elv_next_request() would be:
> if (unlikely(blk_queue_dying(q)) ||
> unlikely(blk_queue_bypass(q)) ||
> !q->elevator->type->ops.elevator_dispatch_fn(q, 0))
> return NULL;

FYI, I've made this change and tested it. I can't say for certain that
it fixes the crash (since it's one of those races that's difficult to
reproduce), but it does seem to pass all the tests I've thrown at it so
Frank Mayhar

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at