Re: [BISECTED] Linux 3.12.7 introduces page map handling regression
From: Linus Torvalds
Date: Wed Jan 22 2014 - 13:24:15 EST
On Wed, Jan 22, 2014 at 10:07 AM, Rik van Riel <riel@xxxxxxxxxx> wrote:
> The difference between a numa pte and a protnone pte is
> the VMA permissions.
If that is indeed the only difference, then we should damn well get
rid of that f*cking stupid _PAGE_NUMA name entirely.
It's misleading crap. Really. Just do a quick grep for that bit, and
you see just *how* confused people are about it:
#define _PAGE_NUMA _PAGE_PROTNONE
if ((pte_flags(a) & (_PAGE_PROTNONE | _PAGE_NUMA)) &
think about it. Just *THINK* about how broken that code is. The whole
thing is a disaster. _PAGE_NUMA must die. It's shit.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/