Re: [PATCH] tracing: Use task_nice() in function __update_max_tr()to get the nice value of task.

[Dongsheng Yang]

On 01/22/2014 11:00 PM, Steven Rostedt wrote:
> Bah, I just noticed that TASK_NICE is in kernel/sched/sched.h not
> include/linux/sched.h
>
> Peter, is there a reason that task_nice() is not a static inline in
> sched.h and have these macros there too? They only reference fields in
> task_struct that are already defined there. I don't see why they need
> to be private to kernel/sched.

Agree. These macros are useful to other modules out of kernel/sched.
But they are private to kernel/sched currently.

If we move them to include/linux/sched.h, I will use TASK_NICE in this 
patch.
> -- Steve
>
> > Thanks,
> >
> > -- Steve
> >
> > >   	max_data->policy = tsk->policy;
> > >   	max_data->rt_priority = tsk->rt_priority;
> > >   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/