Re: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver

[Valentina Manea]

On Thu, Jan 23, 2014 at 9:09 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote:
>> This driver was previously an interface driver. Since USB/IP
>> exports a whole device, not just an interface, it would make
>> sense to be a device driver.
>>
>> This patch also modifies the way userspace sees and uses a
>> shared device - dealing with interfaces is no longer required.
>
> In what way is this modified?  What is now different?
>

1. The usbip_status file is no longer created for interface 0, but for
the whole device (such as
/sys/devices/pci0000:00/0000:00:01.2/usb1/1-1/usbip_status).
2. Per interface information, such as interface class or protocol, is
no longer sent/received. Only device specific information is
transmitted.
3. Since the driver was moved one level below in the USB architecture,
there is no need to bind/unbind each interface, just the device as a
whole.

>
> Please make both of these EXPORT_SYMBOL_GPL(), like the rest of the USB
> symbols are.

Will fix in V2.

Thanks,
Valentina
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/