Re: [RFC PATCH 1/1] module: Make wait module's refcount to zeroprocedure as async

[Jan Engelhardt]

On Monday 2013-09-16 05:47, Rusty Russell wrote:
>
>Here's what I've got in my pending-rebases tree.
>
>@@ -842,6 +818,11 @@ SYSCALL_DEFINE2(delete_module, const char __user *, name_user,
> 		return -EFAULT;
> 	name[MODULE_NAME_LEN-1] = '\0';
> 
>+	if (!(flags & O_NONBLOCK)) {
>+		printk(KERN_WARNING
>+		       "waiting module removal not supported: please upgrade");
>+	}
>+

This patch has come to my attention via the opensuse lists, where
a poster reported about this new user-visible message (it appears
in dmesg!) and rightfully asked: upgrade what component?

It's probably the userspace module loading utility, but it _really_
should say so. There's good room to read that message - a few months
into the future - as "upgrade your kernel" instead ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/