Re: [PATCH] dcache: error out if the name buffer is too short

From: Al Viro
Date: Sun Jan 26 2014 - 12:41:41 EST


On Sun, Jan 26, 2014 at 05:35:36PM +0100, Oleg Nesterov wrote:
> On 01/26, Oleg Nesterov wrote:
> >
> > Al, Denys, unless I am totally confused the "restart" logic is very broken.
> > We can't simply restart because the main loop changes dentry?
>
> Plus prepend_name() can't actually return -ENAMETOOLONG,
> "int error" inside the loop is wrong.

... and already fixed. Said that, the point about restarts is definitely
true. See vfs.git#for-linus - it should propagate in a few
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/