Re: [PATCH -v2] x86: allocate cpumask during check irq vectors

[H. Peter Anvin]

I strongly disagree with putting variables in file scope when function scope will do, but I do like to see static variables before automatics.  Anyway, this is bikeshedding.

Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>* H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>
>> s/global/static/, with a big loud comment why it is okay.
>
>It would be a global no matter which form we use, but for 
>maintainability reasons I generally prefer a static put right before 
>the function that uses it:
>
>	static cpumask_t mask;
>
>	static func(...)
>	{
>	}
>
>That makes it really apparent that it's a global - statics are easily 
>missed when hiding amongst local variables.
>
>Thanks,
>
>	Ingo

-- 
Sent from my mobile phone.  Please pardon brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/