Re: [PATCH v5 10/22] Remove get_xip_mem

From: Matthew Wilcox
Date: Mon Jan 27 2014 - 08:27:00 EST


On Wed, Jan 15, 2014 at 05:46:28PM -0800, Randy Dunlap wrote:
> > +In order to support this method, the storage must be byte-accessable by
>
> byte-accessible

Thanks. Fixed.

> > +- ensuring that there is sufficient locking between reads, writes,
> > + truncates and page faults
>
> truncates, and
> but that's up to you and your editor/proofreader etc. :)

Ooh, do we really get to have a discussion about the Oxford Comma on
linux-kernel? :-)

I haven't actually run this material past my editor (who is my wife, so
I need really convincing arguments to do it your way instead of hers),
but funnily we had a conversation about the Oxford Comma while on holiday
last week. http://en.wikipedia.org/wiki/Serial_comma has a reasonably
exhaustive discourse on the subject, and I learned that she's probably
primarily against it because of her journalism degree.

> > +Even if the kernel or its modules are stored on an filesystem that supports
>
> a

Good catch. I think I started out with 'an fs', then expanded it to
"an filesystem" which of course is nonsense.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/