Re: [PATCH 1/1] usbip/userspace/libsrc/names.c: memory leak

[Dan Carpenter]

On Mon, Jan 27, 2014 at 02:50:04PM -0800, Greg KH wrote:
> On Mon, Jan 27, 2014 at 11:29:48PM +0100, xypron.glpk@xxxxxx wrote:
> > From: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> > 
> > p is freed if NULL.
> 
> Not a real problem, right?
> 
> > p is leaked if second calloc fails.
> 
> You just created a new bug in your "fix" :(
> 
> Please run your patches through scripts/checkpatch.pl, odds are, it
> would have caught this error.
> 

Checkpatch doesn't catch the problems here.  I thought it would have
caught the style issue but apparently it only looks for extra curly
braces when you run it in --file mode.

Fengguang would hopefully have caught the missing curly braces bug with
Coccinelle.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/