Re: [PATCH] x86: Plug racy xAPIC access of CPU hotplug code

[Andi Kleen]

> Of course, we still need irqs off during ICR writes. I thought Andi was
> just suggesting to replace preempt_disable with get_cpu, maybe to
> document why we are disabling preemption here.

Yes that was my point.

Also with irq-off you of course still always have races against
the NMI-level machine check.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/