Re: [RFC][PATCH] mm: sl[uo]b: fix misleading comments
From: David Rientjes
Date: Wed Jan 29 2014 - 00:03:23 EST
On Tue, 28 Jan 2014, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>
> On x86, SLUB creates and handles <=8192-byte allocations internally.
> It passes larger ones up to the allocator. Saying "up to order 2" is,
> at best, ambiguous. Is that order-1? Or (order-2 bytes)? Make
> it more clear.
>
> SLOB commits a similar sin. It *handles* page-size requests, but the
> comment says that it passes up "all page size and larger requests".
>
> SLOB also swaps around the order of the very-similarly-named
> KMALLOC_SHIFT_HIGH and KMALLOC_SHIFT_MAX #defines. Make it
> consistent with the order of the other two allocators.
>
> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/