Re: [PATCH 2/4] power_supply: Introduce Generic Power Supplycharging driver

[Jenny Tc]

On Sat, Jan 25, 2014 at 10:04:03AM -0700, Pavel Machek wrote:
> > +	* Write access using set_property
> > +		* Set Maximum charging current
> > +		* Action: Configure safety charging registers if any. If not no
> > +			  actions expected for this.
> 
> Having property that does nothing sounds evil to me.

No h/w actions expected. But driver action expected. Will fix in next patch set

> > +* POWER_SUPPLY_CHARGER_PROP_ENABLE_CHARGING
> > +	* Write access using set_property
> > +		* Enable/Disable charging. Charger supplies power to platform,
> > +		  but charging is disabled
> 
> This is unclear. Charging is always disabled?

Writing 0, disables charger. Writing 1 enables charging. 

-Jenny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/