Re: [PATCH] pinctrl: Avoid kasprintf/kfree

From: Mark Brown
Date: Thu Jan 30 2014 - 15:50:27 EST


On Thu, Jan 30, 2014 at 12:37:36PM -0800, Joe Perches wrote:

> + char propname[9 + sizeof(int) * 2 + 4] = "pinctrl-";

I'm not sure this is a triumph of legibility - there's several magic
numbers there and it's not blindlingly obvious where the caclculation
came from. Is this really a hot enough code path to benefit from an
optimisation like this?

Attachment: signature.asc
Description: Digital signature