Re: [PATCH] mm, hugetlb: gimme back my page
From: David Rientjes
Date: Thu Jan 30 2014 - 15:58:12 EST
On Thu, 30 Jan 2014, Sasha Levin wrote:
> VM_BUG_ON_PAGE is just a VM_BUG_ON that does dump_page before the BUG().
>
> The only reason to use VM_BUG_ON instead of VM_BUG_ON_PAGE is if the page
> you're working
> with doesn't make sense/isn't useful as debug output.
>
> If doing a dump_page is causing issues somewhere then dump_pages should be
> fixed - instead
> of hiding the problem under the rug by not using it.
>
It sounds like dump_page() isn't necessarily at fault itself but rather
that using it is opening a race even wider that causes this failure to
occur more often than it normally would.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/