Re: [PATCH] block devices: validate block device capacity

From: Mikulas Patocka
Date: Fri Jan 31 2014 - 03:20:41 EST




On Thu, 30 Jan 2014, James Bottomley wrote:

> > So, if you want 64-bit page offsets, you need to increase pgoff_t size,
> > and that will increase the limit for both files and block devices.
>
> No. The point is the page cache mapping of the device uses a
> manufactured inode saved in the backing device. It looks fixable in the
> buffer code before the page cache gets involved.

So if you think you can support 16TiB devices and leave pgoff_t 32-bit,
send a patch that does it.

Until you make it, you should apply the patch that I sent, that prevents
kernel lockups or data corruption when the user uses 16TiB device on
32-bit kernel.

Mikulas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/