Re: [PATCH 1/2] firmware: fix google/gsmi duplicateefivars_sysfs_init()

[Matt Fleming]

On Tue, 28 Jan, at 05:06:21AM, Michel Lespinasse wrote:
> Starting in commit e14ab23dde12b80db4c94b684a2e485b72b16af3,
> efivars_sysfs_init() is called both by itself as an init function,
> and by drivers/firmware/google/gsmi.c gsmi_init().
> 
> This results in runtime warnings such as the following:
> [    5.651330] WARNING: at fs/sysfs/dir.c:530 sysfs_add_one+0xbd/0xe0()
> [    5.657699] sysfs: cannot create duplicate filename '/firmware/gsmi/vars'
> 
> Fixing this by removing the redundant efivars_sysfs_init() call in
> gsmi_init().
> 
> Tested: booted, checked that /firmware/gsmi/vars was still present and
> showed the expected contents.
> 
> Signed-off-by: Michel Lespinasse <walken@xxxxxxxxxx>
> ---
>  drivers/firmware/google/gsmi.c | 7 -------
>  1 file changed, 7 deletions(-)

Oops, my bad.

(If it matters: Acked-by: Matt Fleming <matt.fleming@xxxxxxxxx>)

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/