Re: [PATCH] irq: fix a Kconfig dependency

[David Rientjes]

On Thu, 30 Jan 2014, nitin.a.kamble@xxxxxxxxx wrote:

> From: Nitin A Kamble <nitin.a.kamble@xxxxxxxxx>
> 
> The generic_chip.c uses interfaces from irq_domain.c which is controlled by
> the IRQ_DOMAIN config option.
> 
> Add a select statement in the Kconfig to reflect this requirement.
> 
> Without this fix, the generic_chip.c compilation fails like this:
> 
> linux/kernel/irq/generic-chip.c:400:11:
>   error: 'irq_domain_xlate_onetwocell' undeclared here (not in a function)
> 

You're not specifying which config option you have enabled that selects 
CONFIG_GENERIC_IRQ_CHIP and does not select CONFIG_IRQ_DOMAIN, but it does 
look like there is a dependency here.

So, if this dependency is reasonable, it begs the question of why we have 
CONFIG_GENERIC_IRQ_CHIP at all and shouldn't just make generic-chip.c 
depend on CONFIG_IRQ_DOMAIN.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/