Re: [PATCH 2/4] arm: qcom: Split Qualcomm support into legacy and multiplatform

[Kumar Gala]

On Jan 31, 2014, at 1:34 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> On Friday 31 January 2014 13:25:25 Kumar Gala wrote:
>>> The hotplug.c change sticks out as something that isn't just a move
>>> of code to another place, but deletion of unused code. It would
>>> be nice to split that out into a separate change, possibly together
>>> with the trivial board.c and smp.c changes.
>> 
>> That’s not 100% true, the hotplug.c code implemented msm_cpu_die, which moved into smp.c
>> 
>> I can split out scm*/smp* into a patch to enable smp if that is really desired, but not exactly sure what it gets us.
>> 
> 
> It's not extremely important, I just prefer splitting patches
> that have any kind of functional change from trivial moves.
> 
> If something happens to break for an unforseen reason, it's
> easier to bisect to the patch that does the change.
> 
> 	Arnd

I’ll push my change to hotplug.c into the SMP patch set that Stephen started.

- k

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/