Re: [PATCH] Fix mountpoint reference leakage in linkat

From: Oleg Drokin
Date: Fri Jan 31 2014 - 16:50:47 EST

Next message: Jason Gunthorpe: "[PATCH v2 1/2] dt: Document a compatible entry for MDIO ethernet Phys"
Previous message: Zoran Markovic: "[RFC PATCH] power: move pm_qos update timeout handler to power-efficient workqueue"
In reply to: Jeff Layton: "Re: [PATCH] Fix mountpoint reference leakage in linkat"
Next in thread: Al Viro: "Re: [PATCH] Fix mountpoint reference leakage in linkat"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Maybe something like this (untested) instead?

I think it's just safe to move the out label up along with the old_path freeing.

In all error cases the retry and delegation breaking logic could not be triggered
anyway.

Something like this (lightly tested):

Attachment: 0001-vfs-Fix-mountpoint-reference-leakage-in-linkat.patch
Description: Binary data

Next message: Jason Gunthorpe: "[PATCH v2 1/2] dt: Document a compatible entry for MDIO ethernet Phys"
Previous message: Zoran Markovic: "[RFC PATCH] power: move pm_qos update timeout handler to power-efficient workqueue"
In reply to: Jeff Layton: "Re: [PATCH] Fix mountpoint reference leakage in linkat"
Next in thread: Al Viro: "Re: [PATCH] Fix mountpoint reference leakage in linkat"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]