Re: lustre: remove unnecessary 'magic' from lustre_pack_request

[Oleg Drokin]

Hello!

On Jan 30, 2014, at 12:48 PM, Dave Jones wrote:

> This probably made more sense when the code supported multiple protocol versions,
> but now it's just obfuscation.
> 
> Signed-off-by: Dave Jones <davej@xxxxxxxxxxxxxxxxx>
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> index 464479c0f00b..c319f74b04f6 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> @@ -244,15 +244,7 @@ int lustre_pack_request(struct ptlrpc_request *req, __u32 magic, int count,
> 	LASSERT(lens[MSG_PTLRPC_BODY_OFF] == sizeof(struct ptlrpc_body));
> 
> 	/* only use new format, we don't need to be compatible with 1.4 */

Can you get rid of this line too please?

> -	magic = LUSTRE_MSG_MAGIC_V2;

Bye,
    Oleg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/