Re: [PATCH 7/8] Add 32 bit VDSO time support for 32 bit kernel

[Stefani Seibold]

Am Sonntag, den 02.02.2014, 08:46 -0800 schrieb Andy Lutomirski:
> On Sun, Feb 2, 2014 at 3:27 AM,  <stefani@xxxxxxxxxxx> wrote:
> > From: Stefani Seibold <stefani@xxxxxxxxxxx>
> >
> > This patch add the time support for 32 bit a VDSO to a 32 bit kernel.
> 
> [...]
> 
> Can you address the review comments from last time around?  For
> example, this still seems to have redundant vvar and hpet mappings, it
> doesn't use the VVAR macro, it moves the 32-bit compat vDSO, etc.
> 

I will address the compat VDSO issue.

But the VVAR macro will be not a part of this patch set. If you depend
on this, feel free to create one. From my point of view this is not
feasible without a macro hacking, because the address accessing the vvar
area differs in kernel and VDSO user mode.

I also see no redundant mapping. There are two modes, one is the map of
the kernel area the other maps the VDSO into the user space area. This
is exactly the behaviour of the origin VDSO implementation.
 
> Also, the usual convention is to use [PATCH v2 3/8], etc, as subjects,
> to keep separate versions separate.
> 

Will do this.

- Stefani


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/