Re: [PATCH 10/10] watchdog: xilinx: Enable this driver for Zynq

[Guenter Roeck]

On 02/02/2014 11:01 PM, Michal Simek wrote:
> On 01/31/2014 03:52 PM, Guenter Roeck wrote:
> > On 01/31/2014 06:18 AM, Michal Simek wrote:
> > > Enable this driver for Zynq.
> > > Move it to architecture independent Kconfig part.
> > >
> > > Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> > > ---
> > >
> > > Build tested by zero day testing system.
> > > ---
> > >    drivers/watchdog/Kconfig | 22 +++++++++-------------
> > >    1 file changed, 9 insertions(+), 13 deletions(-)
> > >
> > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > > index 9db5d3c..6120403 100644
> > > --- a/drivers/watchdog/Kconfig
> > > +++ b/drivers/watchdog/Kconfig
> > > @@ -111,6 +111,15 @@ config WM8350_WATCHDOG
> > >          Support for the watchdog in the WM8350 AudioPlus PMIC.  When
> > >          the watchdog triggers the system will be reset.
> > >
> > > +config XILINX_WATCHDOG
> > > +    tristate "Xilinx Watchdog timer"
> > > +    select WATCHDOG_CORE
> >
> > This needs to depend on HAS_IOMEM.
>
> Are you sure?
> I have no problem to do this change.
> Zero day testing system doesn't report any problem with it.
>
> I have checked dependencies and only score, tile and um has NO_IOMEM option
> enables. And below in log is tile with allyesconfig that's why I believe
> this driver has been also tested without any issue.

https://lkml.org/lkml/2014/1/31/123

I would have assumed the same applies here, but if you are sure that it doesn't I am fine.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/