Re: [PATCH v1] clocksource: tegra: Add nvidia,tegra30-timer compat

From: Daniel Lezcano
Date: Mon Feb 03 2014 - 11:39:59 EST


On 01/31/2014 10:29 PM, Andrew Chew wrote:
There are some differences between tegra20's timer registers and tegra30's
(and later). For one thing, the watchdogs don't seem to be present in
tegra20.

"don't seem", so it is an assumption ?

Add this compatibility string in order to be able to distinguish
whether the watchdogs are there or not.

Sorry but I don't get the connection between declaring the tegra30_timer and the log. Can you elaborate please ?

Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>
---
drivers/clocksource/tegra20_timer.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
index d1869f0..73cfa56 100644
--- a/drivers/clocksource/tegra20_timer.c
+++ b/drivers/clocksource/tegra20_timer.c
@@ -218,6 +218,7 @@ static void __init tegra20_init_timer(struct device_node *np)
0x1, 0x1fffffff);
}
CLOCKSOURCE_OF_DECLARE(tegra20_timer, "nvidia,tegra20-timer", tegra20_init_timer);
+CLOCKSOURCE_OF_DECLARE(tegra30_timer, "nvidia,tegra30-timer", tegra20_init_timer);

static void __init tegra20_init_rtc(struct device_node *np)
{



--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/