Re: [PATCH v2] iio: mxs-lradc: remove useless check

[Jonathan Cameron]

On 18/01/14 20:33, Marek Vasut wrote:
> On Saturday, January 18, 2014 at 08:05:18 PM, Alexandre Belloni wrote:
> > Checking the channel number is useless since mxs_lradc_read_raw() is called
> > from a controlled environment and the driver is responsible for filing the
> > struct iio_chan_spec.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/staging/iio/adc/mxs-lradc.c | 4 ----
> >   1 file changed, 4 deletions(-)
>
> Changelog's missing ;-)
>
> Acked-by: Marek Vasut <marex@xxxxxxx>
Applied to the togreg branch of iio.git - will be pushed out as testing for
the autobuilders to play with it.

Thanks.
> > diff --git a/drivers/staging/iio/adc/mxs-lradc.c
> > b/drivers/staging/iio/adc/mxs-lradc.c index 7fc66a6a6e36..d304156ca2f7
> > 100644
> > --- a/drivers/staging/iio/adc/mxs-lradc.c
> > +++ b/drivers/staging/iio/adc/mxs-lradc.c
> > @@ -897,10 +897,6 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
> >   {
> >   	struct mxs_lradc *lradc = iio_priv(iio_dev);
> >
> > -	/* Check for invalid channel */
> > -	if (chan->channel > LRADC_MAX_TOTAL_CHANS)
> > -		return -EINVAL;
> > -
> >   	switch (m) {
> >   	case IIO_CHAN_INFO_RAW:
> >   		if (chan->type == IIO_TEMP)
>
> Best regards,
> Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/