Re: Would devm_regulator_enable be useful ?

[Guenter Roeck]

On Mon, Feb 03, 2014 at 06:21:52PM +0000, Mark Brown wrote:
> On Sat, Feb 01, 2014 at 04:23:59PM -0800, Guenter Roeck wrote:
> 
> As previously mentioned please fix your mailer to word wrap at a
> sensible limit.
> 
I thought I did ;-). I'll try to make sure I only send e-mail to you
using mutt in the future ... but I notice that your line length is
less than the one I configured, so maybe that is the problem here.

> > Seems to me it would be useful to have it, but then devm_clk_enable()
> > doesn't exist either, so I wonder if there is a reason for not having
> > it.
> 
> In both cases enabling and then leaving the resource enabled throughout
> the runtime of the device isn't normally the best practice for using
> them.  You usually want to enable and disable at runtime with mechanisms
> like runtime PM when the device is idle rather than burning power all
> the time and once you start doing that managed resources don't fit so
> well.

Ok, I accept that. I thought that was what devm_xxx_[disable,remove] etc
was for, though.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/