[patch] mm, compaction: avoid isolating pinned pages fix

From: David Rientjes
Date: Mon Feb 03 2014 - 20:21:01 EST


On Tue, 4 Feb 2014, Joonsoo Kim wrote:

> I think that you need more code to skip this type of page correctly.
> Without page_mapped() check, this code makes migratable pages be skipped,
> since if page_mapped() case, page_count() may be more than zero.
>
> So I think that you need following change.
>
> (!page_mapping(page) && !page_mapped(page) && page_count(page))
>

These pages returned by get_user_pages() will have a mapcount of 1 so this
wouldn't actually fix the massive lock contention. page_mapping() is only
going to be NULL for pages off the lru like these are for
PAGE_MAPPING_ANON.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/