Re: + mm-utilc-add-kstrimdup.patch added to -mm tree

From: Andrew Morton
Date: Mon Feb 03 2014 - 21:38:48 EST


On Mon, 03 Feb 2014 17:28:16 -0800 Sebastian Capella <sebastian.capella@xxxxxxxxxx> wrote:

> Quoting David Rientjes (2014-02-03 17:05:04)
> > The last we heard, I think Sebastian is looking to redo this series and
> > this patch is no longer needed. Sebastian?
> Hi David, Alexey,
>
> I am in the process of reworking the patches. I'm not sure if Andrew
> was just interested in having the kstrimdup utility function available.
>
> Isn't it too late to impose userspace trimming of newlines for sysfs?
> It seems already fairly common and expected for the kernel to eat the
> trailing whitespace, or at least ignore it. If we change this won't we
> be breaking userspace / tools / instructions / etc?
>

We have quite a lot of codesites which open-code the newline trimming.
Providing a library function to do this will result in goodness.

That being said, I don't plan to merge kstrimdup() until it has some users.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/