Re: [PATCH] spi: rspi: Only enable interrupts when there's a need towait

From: Mark Brown
Date: Tue Feb 04 2014 - 06:14:46 EST


On Tue, Feb 04, 2014 at 11:06:24AM +0100, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@xxxxxxxxxxxxxx>
>
> rspi_wait_for_interrupt() unconditionally enables interrupts, even when the
> wait condition is already satisfied. This causes a high interrupt load (2
> interrupts/byte for full-duplex Single SPI transfers, 1 interrupt/byte for
> RSPI with TX Only mode, or QSPI in unidirectional Dual or Quad Transfer
> mode).

Applied but I am wondering if the interrupts are really worth it in the
first place especially at higher clock rates - if you can get completion
within a small number of polls it might be more efficient to just do
that rather than take interrupts.

Attachment: signature.asc
Description: Digital signature