Re: [PATCH v11 1/9] Make vsyscall_gtod_data handling x86 generic

[Andy Lutomirski]

On Tue, Feb 4, 2014 at 2:15 AM,  <stefani@xxxxxxxxxxx> wrote:
> From: Stefani Seibold <stefani@xxxxxxxxxxx>
>
> This patch move the vsyscall_gtod_data handling out of vsyscall_64.c
> into an additonal file vsyscall_gtod.c to make the functionality
> available for x86 32 bit kernel.
>
> It also adds a new vsyscall_32.c which setup the VVAR page.

Other than the unconditional __set_fixmap calls, I think this is okay.

(Can you *please* directly answer review comments rather than just
sending out new versions at high speed.  The current approach means
that I need to reread the patch again every time to see how you've
responded, and I'm currently disinclined to believe that a new version
will actually address a review comment *at all*.)

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/