Re: [PATCH v2] pinctrl: protect pinctrl_list add

From: Linus Walleij
Date: Tue Feb 04 2014 - 17:25:32 EST


On Tue, Feb 4, 2014 at 9:07 AM, Stanislaw Gruszka <sgruszka@xxxxxxxxxx> wrote:

> We have few fedora bug reports about list corruption on pinctrl,
> for example:
> https://bugzilla.redhat.com/show_bug.cgi?id=1051918
>
> Most likely corruption happen due lack of protection of pinctrl_list
> when adding new nodes to it. Patch corrects that.
>
> Fixes: 42fed7ba44e ("pinctrl: move subsystem mutex to pinctrl_dev struct")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
> ---
> I only compile tested patch, also did not get test results from bug
> reporters yet. But I'm pretty confident that patch fixes the problem
> and does not cause any other deadlock.
>
> v1 -> v2: point correct first bad commit.

Patch applied. Thanks for bringing this to our attention!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/