RE: [RFCv2 00/10] xhci: re-work command queue management

[David Laight]

From: Dan Williams 
> > Adding another list that will have its own set of bugs seems retrograde top me.
> 
> What bugs?  Please be specific.  The problem to be addressed is not
> the allocation of commands, but that timeouts of one command eat the
> timeout periods of subsequent commands.  I'm thinking a
> single-threaded workqueue better models what the hardware is doing.
> See my comments in patch 1, but that is orthogonal to how the command
> contexts are allocated.

No software is bug free.
The best way to get reasonably bug-free software is the KISS principle
(Keep It Simple Stupid).
You just seem to be adding a lot of additional complexity.
Maybe it would look better if more of the code was factored out of the
call sites.

IIRC at the moment every call site has to:
1) find the trb address that will be used (massive layer break).
2) actually write the trb (through several layers of function call).
3) sort out any timeout (I didn't really look into this bit).
4) ring the bell.

ISTM that the call site should just be a single function call.
If you do that the implementation of the timeouts/completions is
removed from the callers.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/