RE: [PATCH v4 1/1] watchdog: Add tegra watchdog

[Andrew Chew]

> On 02/06/2014 02:05 PM, Andrew Chew wrote:
> > Add a driver for the hardware watchdogs in NVIDIA Tegra SoCs (Tegra30
> > and later).  This driver will configure one watchdog timer that will
> > reset the system in the case of a watchdog timeout.
> >
> > This driver binds to the nvidia,tegra30-timer device node and gets its
> > register base from there.
> >
> > Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>
> > ---
> 
> Hi Andrew,
> 
> > +
> > +	/* This is the timer base. */
> > +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > +	if (!res) {
> > +		dev_err(&pdev->dev, "incorrect resources\n");
> > +		return -ENODEV;
> > +	}
> > +
> 
> I thought I mentioned that before - dem_iomap_resource() creates the very
> same error message and returns an error if NULL is passed as res argument
> to it. So the above error message (and error check) is really redundant.

Sorry about that.  I guess I misunderstood.  I'll send a new one out shortly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/