Re: [PATCH] vt: initialize con_driver->node in con_init

From: Greg KH
Date: Fri Feb 07 2014 - 11:44:00 EST


On Mon, Dec 30, 2013 at 11:11:02AM +0800, Wang YanQing wrote:
> Commit 6db4063c5b72b46e9793b0f141a7a3984ac6facf
> ("[PATCH] VT binding: Add sysfs control to the VT layer")
> add node item into struct con_driver.

That commit was almost a decade ago, is this patch really needed?

> This patch initialize con_driver->node in con_init.

You are saying what it does, not _why_ it is needed or why this change
is happening.

Please rewrite this with more information because as-is, I have no idea
why I should accept this patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/