Re: [PATCH 3/3] sound: Move prototype declaration to header fileoss/pas2.h from oss/pas2_card.c

From: Josh Triplett
Date: Fri Feb 07 2014 - 12:23:54 EST


On Fri, Feb 07, 2014 at 10:16:31PM +0530, Rashika Kheria wrote:
> Move prototype declaration of function to header file oss/pas2.h
> from oss/pas2_card.c because it is used by more than one file.
>
> This eliminates the following warnings in oss/pas2_mixer.c:
> sound/oss/pas2_mixer.c:62:1: warning: no previous prototype for âmix_writeâ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

> sound/oss/pas2.h | 3 +++
> sound/oss/pas2_card.c | 2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/oss/pas2.h b/sound/oss/pas2.h
> index fa12c55..d19f757 100644
> --- a/sound/oss/pas2.h
> +++ b/sound/oss/pas2.h
> @@ -15,3 +15,6 @@ int pas_init_mixer(void);
> /* From pas_midi.c */
> void pas_midi_init(void);
> void pas_midi_interrupt(void);
> +
> +/* From pas2_mixer.c*/
> +void mix_write(unsigned char data, int ioaddr);
> diff --git a/sound/oss/pas2_card.c b/sound/oss/pas2_card.c
> index 7004e24..b07954a 100644
> --- a/sound/oss/pas2_card.c
> +++ b/sound/oss/pas2_card.c
> @@ -74,8 +74,6 @@ static char *pas_model_names[] = {
> * to support other than the default base address
> */
>
> -extern void mix_write(unsigned char data, int ioaddr);
> -
> unsigned char pas_read(int ioaddr)
> {
> return inb(ioaddr + pas_translate_code);
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/