Re: [patch] drop_caches: add some documentation and info message

[Rik van Riel]

On 02/07/2014 12:40 PM, Johannes Weiner wrote:

> @@ -59,6 +60,9 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
>   	if (ret)
>   		return ret;
>   	if (write) {
> +		printk_ratelimited(KERN_INFO "%s (%d): dropped kernel caches: %d\n",
> +				   current->comm, task_pid_nr(current),
> +				   sysctl_drop_caches);
>   		if (sysctl_drop_caches & 1)
>   			iterate_supers(drop_pagecache_sb, NULL);
>   		if (sysctl_drop_caches & 2)

Would it be better to print this after the operation
has completed?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/